Changeset f79d65 for src/UIElements/Dialog.hpp

Timestamp:

Jun 19, 2017, 8:24:16 AM (8 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.1, ChangeBugEmailaddress, ChemicalSpaceEvaluator, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, Fix_Verbose_Codepatterns, ForceAnnealing_oldresults, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps

Children:

1ba51c

Parents:

2eded3e

git-author:

Frederik Heber <heber@…> (03/30/17 21:59:00)

git-committer:

Frederik Heber <frederik.heber@…> (06/19/17 08:24:16)

Message:

Vector(s) are now stored as strings in Querys intermediately.

• they get evaluated first after being stored in a Parameter/Value on request via get().
• Needed to change all Vector(s)..Query's of all UIs and also the general base classes inside Dialog.
• QtQueryList need to be specialized in order to allow a QtQueryList<Vector> to actually store a vector of strings.
• we may use setAsString() in order to set the Parameter thankfully.
• TESTS: All regression tests on Geometry Actions are now working. Removed XFAIL from Options/Session test that use Python, i.e. the ones we marked four commits ago.

File:

• src/UIElements/Dialog.hpp (modified) (2 diffs)

src/UIElements/Dialog.hpp

@@ -304 +304 @@
   virtual ~TQuery(){}
   virtual bool handle()=0;
-  virtual bool isValid(){ return param.isValid(temp);  }
-  virtual void setResult(){ param.set(temp);  }
+  virtual bool isValid(){ return param.isValidAsString(temp);  }
+  virtual void setResult(){ param.setAsString(temp);  }
 protected:
-  Vector temp;
+  std::string temp;
   Parameter<Vector> &param;
 };
@@ -318 +318 @@
   virtual ~TQuery(){}
   virtual bool handle()=0;
-  virtual bool isValid(){ return param.isValid(temp);  }
-  virtual void setResult(){ param.set(temp);  }
+  virtual bool isValid();
+  virtual void setResult();
 protected:
-  std::vector<Vector> temp;
+  std::vector<std::string> temp;
   Parameter< std::vector<Vector> > &param;
 };