Changeset f2d5ce for src/UIElements/Views/Qt4/QtTimeLine.hpp

Timestamp:

Dec 26, 2025, 9:40:14 PM (6 days ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.1, stable

Children:

c8cb0d

Parents:

bdd1d0

git-author:

Frederik Heber <frederik.heber@…> (12/10/25 10:20:56)

git-committer:

Frederik Heber <frederik.heber@…> (12/26/25 21:40:14)

Message:

QtTimeLine no longers queries WorldTime directly.

• This was slightly prone to race conditions when manipulating the slider in the UI while stuff was going on in the background. Instead, we query the QtObservedInstanceBoard.
• QtObservedInstanceBoard has ObservedValue for WorldTime.
• introduces ObservedMaximumAtomTrajectorySize that aggregates the maximum trajectory size over all atoms and provides it as an Observable. We need this value in QtTimeLine only right now.

File:

• src/UIElements/Views/Qt4/QtTimeLine.hpp (modified) (2 diffs)

src/UIElements/Views/Qt4/QtTimeLine.hpp

@@ -20 +20 @@
 #include <boost/thread/recursive_mutex.hpp>
 
-#include "CodePatterns/Observer/Observer.hpp"
+class QtObservedInstanceBoard;
 
-class QtTimeLine : public QWidget, public Observer
+class QtTimeLine : public QWidget
 {
   Q_OBJECT
 
 public:
-  QtTimeLine(QWidget * _parent=0);
+  QtTimeLine(QtObservedInstanceBoard *_instanceBoard, QWidget * _parent=0);
   virtual ~QtTimeLine();
 
 protected:
-  virtual void update(Observable *publisher);
-  virtual void recieveNotification(Observable *publisher, Notification_ptr notification);
-  virtual void subjectKilled(Observable *publisher);
   virtual void paintEvent(QPaintEvent * event);
 
@@ -39 +36 @@
   void StepUpdate(int position);
 
+public slots:
+  void WorldTimeChanged();
+  void MaximumAtomTrajectoryChanged();
+
 private:
-  //!> whether AtomObserver knows about us or not
-  bool atomobserver_enlisted;
-  //!> whether WorldTime knows about us or not
-  bool worldtime_enlisted;
-
   QSlider *slider;
   QSpinBox *spinbox;
   QHBoxLayout *layout;
+
+  //!> instance board with observed world time
+  QtObservedInstanceBoard *instanceBoard;
 
   //!> states whether we are expecting a notification from the worldtime