Changeset 9ac3d3 for ThirdParty/CodePatterns/src/Observer/Notification.cpp

Timestamp:

Jul 19, 2018, 2:39:51 PM (7 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.6.1

Children:

209f4c

Parents:

ca2880

git-author:

Frederik Heber <frederik.heber@…> (07/19/18 14:39:04)

git-committer:

Frederik Heber <frederik.heber@…> (07/19/18 14:39:51)

Message:

FIX: Constrained locking in CodePattern's Notification and Observable.

• this is not a full soluton to possible race conditions with Qt's own threading but seems to help for the guichecks.

File:

• ThirdParty/CodePatterns/src/Observer/Notification.cpp (modified) (1 diff)

ThirdParty/CodePatterns/src/Observer/Notification.cpp

@@ -52 +52 @@
 void Notification::notifyAll(Observable * const publisher)
 {
-  boost::recursive_mutex::scoped_lock guard(TargetsLock);
-  // copy such that signOff() within receiving update() does not affect iterating
-  // this is because within the same thread and with the update() signOff() may be
-  // called and when executed it modifies targets
-  targets_t temp_targets = targets;
+  targets_t temp_targets;
+  {
+    boost::recursive_mutex::scoped_lock guard(TargetsLock);
+    // copy such that signOff() within receiving update() does not affect iterating
+    // this is because within the same thread and with the update() signOff() may be
+    // called and when executed it modifies targets
+    temp_targets = targets;
+  }
   for(targets_t::iterator it=temp_targets.begin();
       it!=temp_targets.end();++it){