Changeset 71910a for molecuilder/src/unittests/ActOnAllUnitTest.cpp

Timestamp:

Apr 7, 2010, 3:45:38 PM (16 years ago)

Author:

Tillmann Crueger <crueger@…>

Children:

0f55b2

Parents:

770138

Message:

Made data internal data-structure of vector class private

• Replaced occurences of access to internals with operator
• moved Vector-class into LinAlg-Module
• Reworked Vector to allow clean modularization
• Added Plane class to describe arbitrary planes in 3d space

File:

• molecuilder/src/unittests/ActOnAllUnitTest.cpp (modified) (2 diffs)

molecuilder/src/unittests/ActOnAllUnitTest.cpp

@@ -99 +99 @@
 };
 
+#if 0
+
+// Unitttest deactivated for now...
+// Reasons:
+//    Vector::MakeNormalVector has been removed and is now part of Plane class
+//    VectorList::ActOnAll is in the test directory and seems to be used only for unittests
+//    MakeNormal never depended on the input Vector except in the case of linear dependence (i.e. failure)
+//
+// TODO: Rethink what exactely is being tested at this point and introduce a new unittest for the
+//       tested behaviour. Most likely this should result in a thourough unittest of the plane class
+
 /** UnitTest for VectorList::ActOnAll() and Vector::MakeNormalVector()
  */
@@ -113 +124 @@
   // check that x and y components are zero
   for (ListOfVectors::iterator Runner = VL.Vectors.begin(); Runner != VL.Vectors.end(); Runner++) {
-    CPPUNIT_ASSERT_EQUAL( (*Runner)->x[0] , 0. );
-    CPPUNIT_ASSERT_EQUAL( (*Runner)->x[1] , 0. );
+    CPPUNIT_ASSERT_EQUAL( (*Runner)->at(0) , 0. );
+    CPPUNIT_ASSERT_EQUAL( (*Runner)->at(1) , 0. );
   }
 };
+
+#endif