Changeset 471dec for src/Tesselation/BoundaryTriangleSet.cpp

Timestamp:

Mar 28, 2012, 1:23:11 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

03a713

Parents:

368207

git-author:

Frederik Heber <heber@…> (03/14/12 20:22:42)

git-committer:

Frederik Heber <heber@…> (03/28/12 13:23:11)

Message:

Added BoundaryTriangleSet::IsInsideTriangle().

• this is preparatory for finding a bug in GetClosestPointInsideTriangle().
• refactored in-test triangle creation into distinct function.
• added extensive unit test on this function.

File:

• src/Tesselation/BoundaryTriangleSet.cpp (modified) (1 diff)

src/Tesselation/BoundaryTriangleSet.cpp

@@ -371 +371 @@
 ;
 
+/** Checks whether a given point is inside the plane of the triangle and inside the
+ * bounds defined by its BoundaryLineSet's.
+ *
+ * @param point point to check
+ * @return true - point is inside place and inside all BoundaryLine's
+ */
+bool BoundaryTriangleSet::IsInsideTriangle(const Vector &point) const
+{
+  Info FunctionInfo(__func__);
+
+  // check if it's inside the plane
+  try {
+    Plane trianglePlane(
+        endpoints[0]->node->getPosition(),
+        endpoints[1]->node->getPosition(),
+        endpoints[2]->node->getPosition());
+    if (!trianglePlane.isContained(point)) {
+      LOG(1, "INFO: Point " << point << " is not inside plane " << trianglePlane << " by "
+          << trianglePlane.distance(point) << ".");
+      return false;
+    }
+  } catch(LinearDependenceException) {
+    // triangle is degenerated, it's just a line (i.e. one endpoint is right in between two others
+    for (size_t i = 0; i < NDIM; ++i) {
+      try {
+        Line l = makeLineThrough(
+            lines[i]->endpoints[0]->node->getPosition(),
+            lines[i]->endpoints[1]->node->getPosition());
+        if (l.isContained(GetThirdEndpoint(lines[i])->node->getPosition())) {
+          // we have the largest of the three lines
+          LOG(1, "INFO: Linear-dependent case where point " << point << " is on line " << l << ".");
+          return (l.isContained(point));
+        }
+      } catch(ZeroVectorException) {
+        // two points actually coincide
+        try {
+          Line l = makeLineThrough(
+              lines[i]->endpoints[0]->node->getPosition(),
+              GetThirdEndpoint(lines[i])->node->getPosition());
+          LOG(1, "INFO: Degenerated case where point " << point << " is on line " << l << ".");
+          return (l.isContained(point));
+        } catch(ZeroVectorException) {
+          // all three points coincide
+          if (point.DistanceSquared(lines[i]->endpoints[0]->node->getPosition()) < MYEPSILON) {
+            LOG(1, "INFO: Full-Degenerated case where point " << point << " is on three endpoints "
+                << lines[i]->endpoints[0]->node->getPosition() << ".");
+            return true;
+          }
+          else return false;
+        }
+      }
+    }
+  }
+
+  // check whether it lies on the correct side as given by third endpoint for
+  // each BoundaryLine.
+  // NOTE: we assume here that endpoints are linear independent, as the case
+  // has been caught before already extensively
+  for (size_t i = 0; i < NDIM; ++i) {
+    Line l = makeLineThrough(
+        lines[i]->endpoints[0]->node->getPosition(),
+        lines[i]->endpoints[1]->node->getPosition());
+    Vector onLine( l.getClosestPoint(point) );
+    LOG(1, "INFO: Closest point on boundary line is " << onLine << ".");
+    Vector inTriangleDirection( GetThirdEndpoint(lines[i])->node->getPosition() - onLine );
+    Vector inPointDirection(point - onLine);
+    if ((inTriangleDirection.NormSquared() > MYEPSILON) && (inPointDirection.NormSquared() > MYEPSILON))
+      if (inTriangleDirection.ScalarProduct(inPointDirection) < -MYEPSILON)
+        return false;
+  }
+
+  return true;
+}
+
+
 /** Returns the endpoint which is not contained in the given \a *line.
  * \param *line baseline defining two endpoints