Changeset f3d16a for src/CodePatterns/Observer

Timestamp:

Jul 14, 2014, 8:36:58 PM (11 years ago)

Author:

Frederik Heber <heber@…>

Children:

e93bfe

Parents:

44f368

git-author:

Frederik Heber <heber@…> (10/15/13 13:31:42)

git-committer:

Frederik Heber <heber@…> (07/14/14 20:36:58)

Message:

FIX: Fixes to Graveyard and Zombies.

Location:

src/CodePatterns/Observer

Files:

• Observable.hpp (modified) (2 diffs)
• Zombie.hpp (modified) (1 diff)

src/CodePatterns/Observer/Observable.hpp

@@ -141 +141 @@
   typedef boost::function<void (const Observable*)> graveyard_informer_t;
 
-  //!> bound function to call when Observer are signing off
-  graveyard_informer_t &graveyard_informer;
+  /** Bound function to call when Observer are signing off (needs to be a ptr
+   * as we must be able to rebound it.
+   *
+   * \warning Do not delete this pointer, the instance is either a static one
+   * or handled someplace else (e.g. in the Graveyard).
+   */
+  graveyard_informer_t * graveyard_informer;
 
   //!> default informer that does nothing
@@ -149 +154 @@
   /** Sets the bound function for over-time life-time management.
    *
-   * \param _graveyard Graveyard to inform of leaving Observers
+   * \param _graveyard ptr Graveyard to inform of leaving Observers
    */
-  void setGraveyardInformer(graveyard_informer_t &_graveyard_informer)
+  void setGraveyardInformer(graveyard_informer_t * _graveyard_informer)
   {
     graveyard_informer = _graveyard_informer;

src/CodePatterns/Observer/Zombie.hpp

@@ -34 +34 @@
    *
    * Is private to allow only Graveyard to instantiate them.
+   *
+   * \param _observable observable to wrap, ptr is NULL'd
+   * \param _graveyard_informer callback when Observers are signOff()'ing
    */
   Zombie(
       Observable *& _observable,
-      Observable::graveyard_informer_t _graveyard_informer) :
+      Observable::graveyard_informer_t *_graveyard_informer) :
     m_observable(_observable)
   {