Changeset d3926b5


Ignore:
Timestamp:
Feb 21, 2011, 3:46:02 PM (15 years ago)
Author:
Frederik Heber <heber@…>
Children:
d1e0c0
Parents:
7fff6c
git-author:
Frederik Heber <heber@…> (02/14/11 22:12:10)
git-committer:
Frederik Heber <heber@…> (02/21/11 15:46:02)
Message:

BUGFIX: ObservedContainer::reverse_iterator was wrong way implemnted.

  • Library version is now 4:0:4, API version is still 1.0.9.
  • reverse_iterator had begin(), end() messed in cstor.
  • added unit test on ObservedContainer.
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • configure.ac

    r7fff6c rd3926b5  
    33
    44AC_PREREQ([2.65])
    5 AC_INIT([CodePatterns], [1.0.8], [heber@ins.uni-bonn.de], [codepatterns], [http://trac.ins.uni-bonn.de/projects/CodePatterns/])
     5AC_INIT([CodePatterns], [1.0.9], [heber@ins.uni-bonn.de], [codepatterns], [http://trac.ins.uni-bonn.de/projects/CodePatterns/])
    66AC_CONFIG_AUX_DIR(config)
    77AC_CONFIG_SRCDIR([src/Patterns/Singleton_impl.hpp])
    … …  
    2525# refer to the libtool manual, section "Updating library version information":
    2626# http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
    27 AC_SUBST([CODEPATTERNS_SO_VERSION], [4:0:3])
    28 AC_SUBST([CODEPATTERNS_API_VERSION], [1.0.8])
     27AC_SUBST([CODEPATTERNS_SO_VERSION], [4:0:4])
     28AC_SUBST([CODEPATTERNS_API_VERSION], [1.0.9])
    2929
    3030# Checks for libraries.

  • src/Patterns/ObservedContainer.hpp

    r7fff6c rd3926b5  
    1414#endif
    1515
    16 #include "types.hpp"
    17 
    1816#include <utility>
    1917#include "ObservedIterator.hpp"
    20 #include "Descriptors/SelectiveIterator.hpp"
    21 
    22 class World;
    23 class atom;
    24 class AtomDescriptor;
    2518
    2619/**
    … …  
    3427class ObservedContainer
    3528{
    36   friend class World;
    37 
    3829public:
    3930  typedef Container set_t;
    … …  
    4637  typedef ObservedIterator<set_t>                               iterator;
    4738  typedef typename set_t::const_iterator                        const_iterator;
    48   typedef std::reverse_iterator<iterator>                       reverse_iterator;
     39  typedef typename std::reverse_iterator<iterator>              reverse_iterator;
    4940  typedef typename std::reverse_iterator<const_iterator>        const_reverse_iterator;
    5041

  • src/Patterns/ObservedContainer_impl.hpp

    r7fff6c rd3926b5  
    7171typename ObservedContainer<Container>::reverse_iterator
    7272ObservedContainer<Container>::rbegin(){
    73   return reverse_iterator(begin());
     73  return reverse_iterator(end());
    7474}
    7575
    … …  
    7878typename ObservedContainer<Container>::const_reverse_iterator
    7979ObservedContainer<Container>::rbegin() const{
    80   return const_reverse_iterator(begin());
     80  return const_reverse_iterator(end());
    8181}
    8282
    … …  
    8585typename ObservedContainer<Container>::reverse_iterator
    8686ObservedContainer<Container>::rend(){
    87   return reverse_iterator(end());
     87  return reverse_iterator(begin());
    8888}
    8989
    … …  
    9292typename ObservedContainer<Container>::const_reverse_iterator
    9393ObservedContainer<Container>::rend() const{
    94   return const_reverse_iterator(end());
     94  return const_reverse_iterator(begin());
    9595}
    9696

  • src/Patterns/unittests/Makefile.am

    r7fff6c rd3926b5  
    1515  ManipulableCloneUnitTest \
    1616  ManipulablePrototypeFactoryUnitTest \
     17  ObservedContainerUnitTest \
    1718  ObserverUnitTest \
    1819  PrototypeFactoryUnitTest \
    … …  
    106107nodist_ObserverUnitTest_SOURCES = \
    107108        ../Observer.hpp \
     109        ../ObserverContainer.hpp \
     110        ../ObserverContainer_impl.hpp \
    108111        ../ObserverIterator.hpp
    109112ObserverUnitTest_LDADD = $(TESTLIBS)
     113
     114ObservedContainerUnitTest_SOURCES = $(top_srcdir)/src/unittests/UnitTestMain.cpp \
     115        ObservedContainerUnitTest.cpp \
     116        ObservedContainerUnitTest.hpp \
     117        stubs/ObserverStub.cpp \
     118        stubs/ObserverStub.hpp
     119nodist_ObservedContainerUnitTest_SOURCES = \
     120        ../ObserverContainer.hpp \
     121        ../ObserverContainer_impl.hpp
     122ObservedContainerUnitTest_LDADD = $(TESTLIBS)
    110123
    111124PrototypeFactoryUnitTest_SOURCES = $(top_srcdir)/src/unittests/UnitTestMain.cpp \

  • src/Patterns/unittests/ObserverUnitTest.cpp

    r7fff6c rd3926b5  
    2828
    2929#include "stubs/ObserverStub.hpp"
     30#include "ObservedContainer.hpp"
     31#include "ObservedContainer_impl.hpp"
    3032
    3133#include "ObserverUnitTest.hpp"
Note: See TracChangeset for help on using the changeset viewer.