Changeset be21fa for src/Actions/WorldAction

Timestamp:

Apr 11, 2012, 4:53:04 PM (14 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, Candidate_v1.7.0, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

b2c302

Parents:

3e93332

git-author:

Frederik Heber <heber@…> (04/11/12 16:18:23)

git-committer:

Frederik Heber <heber@…> (04/11/12 16:53:04)

Message:

Moved getParametersfromValueStorage() call from each single Action into base class Action::call().

Location:

src/Actions/WorldAction

Files:

• AddEmptyBoundaryAction.cpp (modified) (1 diff)
• BoundInBoxAction.cpp (modified) (1 diff)
• CenterInBoxAction.cpp (modified) (1 diff)
• CenterOnEdgeAction.cpp (modified) (1 diff)
• ChangeBoxAction.cpp (modified) (1 diff)
• InputAction.cpp (modified) (1 diff)
• OutputAction.cpp (modified) (1 diff)
• RepeatBoxAction.cpp (modified) (1 diff)
• ScaleBoxAction.cpp (modified) (1 diff)
• SetBoundaryConditionsAction.cpp (modified) (1 diff)
• SetDefaultNameAction.cpp (modified) (1 diff)
• SetWorldTimeAction.cpp (modified) (1 diff)

src/Actions/WorldAction/AddEmptyBoundaryAction.cpp

@@ -49 +49 @@
   Vector Max;
   int j=0;
-
-  // obtain information
-  getParametersfromValueStorage();
 
   // create undo domain

src/Actions/WorldAction/BoundInBoxAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr WorldBoundInBoxAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   // create undo state
   std::vector< boost::shared_ptr<Vector> > OldPositions;

src/Actions/WorldAction/CenterInBoxAction.cpp

@@ -47 +47 @@
 /** =========== define the function ====================== */
 Action::state_ptr WorldCenterInBoxAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   // create undo state
   std::stringstream undostream;

src/Actions/WorldAction/CenterOnEdgeAction.cpp

@@ -48 +48 @@
   Vector Min;
   Vector Max;
-
-  // obtain information
-  getParametersfromValueStorage();
 
   // create undo state

src/Actions/WorldAction/ChangeBoxAction.cpp

@@ -44 +44 @@
 /** =========== define the function ====================== */
 Action::state_ptr WorldChangeBoxAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   // create undo state
   std::stringstream undostream;

src/Actions/WorldAction/InputAction.cpp

@@ -45 +45 @@
   boost::filesystem::ifstream test;
   FormatParserStorage &parsers = FormatParserStorage::getInstance();
-
-  // obtain information
-  getParametersfromValueStorage();
 
   LOG(0, "Config file given " << params.filename << ".");

src/Actions/WorldAction/OutputAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr WorldOutputAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Storing world to file " << params.filename << ".");
 

src/Actions/WorldAction/RepeatBoxAction.cpp

@@ -96 +96 @@
 
 Action::state_ptr WorldRepeatBoxAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<molecule *> AllMolecules;
   DoLog(0) && (Log() << Verbose(0) << "Using all molecules." << endl);

src/Actions/WorldAction/ScaleBoxAction.cpp

@@ -41 +41 @@
 Action::state_ptr WorldScaleBoxAction::performCall() {
   double x[NDIM];
-
-  // obtain information
-  getParametersfromValueStorage();
 
   // scale atoms

src/Actions/WorldAction/SetBoundaryConditionsAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr WorldSetBoundaryConditionsAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   // gather undo information
   std::stringstream undostream;

src/Actions/WorldAction/SetDefaultNameAction.cpp

@@ -40 +40 @@
   WorldSetDefaultNameState *UndoState = new WorldSetDefaultNameState(Worldsdefaultname, params);
 
-  // obtain information
-  getParametersfromValueStorage();
-
   World::getInstance().setDefaultName(params.newname);
   LOG(0, "Default name of new molecules set to " << World::getInstance().getDefaultName() << ".");

src/Actions/WorldAction/SetWorldTimeAction.cpp

@@ -41 +41 @@
   WorldSetWorldTimeState *UndoState = new WorldSetWorldTimeState(oldtime, params);
 
-  // obtain information
-  getParametersfromValueStorage();
-
   WorldTime::getInstance().setTime(params.newtime);
   LOG(0, "Current time step is now: " << WorldTime::getTime() << ".");