Changeset add42a

Timestamp:

Jul 21, 2010, 3:25:04 PM (15 years ago)

Author:

Tillmann Crueger <crueger@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

fefe0d

Parents:

a6d6a9

Message:

Removed reverse formula iterators, because they would cause memory corruptions

Location:

src

Files:

• Formula.cpp (modified) (6 diffs)
• Formula.hpp (modified) (2 diffs)

src/Formula.cpp

@@ -9 +9 @@
 
 #include <sstream>
+#include <iostream>
 
 #include "World.hpp"
@@ -44 +45 @@
 std::string Formula::toString() const{
   stringstream sstr;
-  for(const_reverse_iterator iter=rbegin();iter!=rend();++iter){
+  for(const_iterator iter=end();iter!=begin();){
+    --iter;
     sstr << (*iter).first->symbol;
     if((*iter).second>1)
@@ -71 +73 @@
       throw(ParseError(__FILE__,__LINE__));
     shorthand+=(*it++);
+    cout << "Beginning of shorthand read: " << shorthand << endl;
     // the rest of the name follows
     while(it!=end && isInRange(SmallLetters,(*it)))
       shorthand+=(*it++);
+    cout << "Full shorthand read: " << shorthand << endl;
     // now we can count the occurences
     int count = 0;
     while(it!=end && isInRange(Numbers,(*it)))
       count = (count*10) + ((*it++)-Numbers.first);
+    cout << "Count read: " << count << endl;
     // one is implicit
     count = (count!=0)?count:1;
+    cout << "Corrected implicit count: " << count << endl;
     // done, we can get the next one
     addElements(shorthand,count);
@@ -173 +179 @@
   ASSERT(World::getInstance().getPeriode()->FindElement(Z),"No Element with this number in Periodentafel");
   elementCounts.resize(Z); // No-op when we already have the right size
+  cout << "Adding " << count << " to element with number " << Z << endl;
   // might need to update number of elements
   if(!elementCounts[Z-1]){
@@ -178 +185 @@
   }
   elementCounts[Z-1]+=count;
+  cout << "Element ist now " << elementCounts[Z-1] << endl;
 }
 
@@ -232 +240 @@
 Formula::const_iterator Formula::end() const{
   return const_iterator(elementCounts);
-}
-
-Formula::reverse_iterator Formula::rbegin(){
-  return reverse_iterator(end());
-}
-Formula::const_reverse_iterator Formula::rbegin() const{
-  return const_reverse_iterator(end());
-}
-Formula::reverse_iterator Formula::rend(){
-  return reverse_iterator(begin());
-}
-Formula::const_reverse_iterator Formula::rend() const{
-  return const_reverse_iterator(begin());
 }
 

src/Formula.hpp

@@ -52 +52 @@
   typedef _iterator<value_type>                 iterator;
   typedef _iterator<const value_type>           const_iterator;
-  typedef std::reverse_iterator<iterator>       reverse_iterator;
-  typedef std::reverse_iterator<const_iterator> const_reverse_iterator;
 
   Formula();
@@ -97 +95 @@
   const_iterator end()   const;
 
-  reverse_iterator       rbegin();
-  const_reverse_iterator rbegin() const;
-  reverse_iterator       rend();
-  const_reverse_iterator rend()   const;
-
   void clear();