Changeset 9eb71b3 for src/Actions/SelectionAction

Timestamp:

May 5, 2017, 2:08:59 PM (8 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.1, Candidate_v1.7.0, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes, stable

Children:

ac9dc8

Parents:

aa91de0

git-author:

Frederik Heber <frederik.heber@…> (05/05/17 12:22:20)

git-committer:

Frederik Heber <frederik.heber@…> (05/05/17 14:08:59)

Message:

Commented out MemDebug include and Memory::ignore.

• MemDebug clashes with various allocation operators that use a specific placement in memory. It is so far not possible to wrap new/delete fully. Hence, we stop this effort which so far has forced us to put ever more includes (with clashes) into MemDebug and thereby bloat compilation time.
• MemDebug does not add that much usefulness which is not also provided by valgrind.

Location:

src/Actions/SelectionAction

Files:

• Atoms/AllAtomsAction.cpp (modified) (1 diff)
• Atoms/AllAtomsInsideVolumeAction.cpp (modified) (1 diff)
• Atoms/AllAtomsOfMoleculeAction.cpp (modified) (1 diff)
• Atoms/AtomByElementAction.cpp (modified) (1 diff)
• Atoms/AtomByIdAction.cpp (modified) (1 diff)
• Atoms/AtomByOrderAction.cpp (modified) (1 diff)
• Atoms/ClearAllAtomsAction.cpp (modified) (1 diff)
• Atoms/InvertAtomsAction.cpp (modified) (1 diff)
• Atoms/NotAllAtomsAction.cpp (modified) (1 diff)
• Atoms/NotAllAtomsInsideVolumeAction.cpp (modified) (1 diff)
• Atoms/NotAllAtomsOfMoleculeAction.cpp (modified) (1 diff)
• Atoms/NotAtomByElementAction.cpp (modified) (1 diff)
• Atoms/NotAtomByIdAction.cpp (modified) (1 diff)
• Atoms/NotAtomByOrderAction.cpp (modified) (1 diff)
• Atoms/PopAtomsAction.cpp (modified) (1 diff)
• Atoms/PushAtomsAction.cpp (modified) (1 diff)
• Molecules/AllMoleculesAction.cpp (modified) (1 diff)
• Molecules/ClearAllMoleculesAction.cpp (modified) (1 diff)
• Molecules/InvertMoleculesAction.cpp (modified) (1 diff)
• Molecules/MoleculeByFormulaAction.cpp (modified) (1 diff)
• Molecules/MoleculeByIdAction.cpp (modified) (1 diff)
• Molecules/MoleculeByNameAction.cpp (modified) (1 diff)
• Molecules/MoleculeByOrderAction.cpp (modified) (1 diff)
• Molecules/MoleculeOfAtomAction.cpp (modified) (1 diff)
• Molecules/NotAllMoleculesAction.cpp (modified) (1 diff)
• Molecules/NotMoleculeByFormulaAction.cpp (modified) (1 diff)
• Molecules/NotMoleculeByIdAction.cpp (modified) (1 diff)
• Molecules/NotMoleculeByNameAction.cpp (modified) (1 diff)
• Molecules/NotMoleculeByOrderAction.cpp (modified) (1 diff)
• Molecules/NotMoleculeOfAtomAction.cpp (modified) (1 diff)
• Molecules/PopMoleculesAction.cpp (modified) (1 diff)
• Molecules/PushMoleculesAction.cpp (modified) (1 diff)
• Shapes/AllShapesAction.cpp (modified) (1 diff)
• Shapes/NotAllShapesAction.cpp (modified) (1 diff)
• Shapes/NotShapeByNameAction.cpp (modified) (1 diff)
• Shapes/ShapeByNameAction.cpp (modified) (1 diff)

src/Actions/SelectionAction/Atoms/AllAtomsAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomDescriptor.hpp"

src/Actions/SelectionAction/Atoms/AllAtomsInsideVolumeAction.cpp

@@ -34 +34 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomShapeDescriptor.hpp"

src/Actions/SelectionAction/Atoms/AllAtomsOfMoleculeAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomSelectionDescriptor.hpp"

src/Actions/SelectionAction/Atoms/AtomByElementAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomTypeDescriptor.hpp"

src/Actions/SelectionAction/Atoms/AtomByIdAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Atom/atom.hpp"

src/Actions/SelectionAction/Atoms/AtomByOrderAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Atom/atom.hpp"

src/Actions/SelectionAction/Atoms/ClearAllAtomsAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomDescriptor.hpp"

src/Actions/SelectionAction/Atoms/InvertAtomsAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomDescriptor.hpp"

src/Actions/SelectionAction/Atoms/NotAllAtomsAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomDescriptor.hpp"

src/Actions/SelectionAction/Atoms/NotAllAtomsInsideVolumeAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomSelectionDescriptor.hpp"

src/Actions/SelectionAction/Atoms/NotAllAtomsOfMoleculeAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomSelectionDescriptor.hpp"

src/Actions/SelectionAction/Atoms/NotAtomByElementAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/AtomSelectionDescriptor.hpp"

src/Actions/SelectionAction/Atoms/NotAtomByIdAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Atom/atom.hpp"

src/Actions/SelectionAction/Atoms/NotAtomByOrderAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Atom/atom.hpp"

src/Actions/SelectionAction/Atoms/PopAtomsAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <boost/bind.hpp>

src/Actions/SelectionAction/Atoms/PushAtomsAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Log.hpp"

src/Actions/SelectionAction/Molecules/AllMoleculesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeDescriptor.hpp"

src/Actions/SelectionAction/Molecules/ClearAllMoleculesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeDescriptor.hpp"

src/Actions/SelectionAction/Molecules/InvertMoleculesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeDescriptor.hpp"

src/Actions/SelectionAction/Molecules/MoleculeByFormulaAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeFormulaDescriptor.hpp"

src/Actions/SelectionAction/Molecules/MoleculeByIdAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "molecule.hpp"

src/Actions/SelectionAction/Molecules/MoleculeByNameAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeNameDescriptor.hpp"

src/Actions/SelectionAction/Molecules/MoleculeByOrderAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "molecule.hpp"

src/Actions/SelectionAction/Molecules/MoleculeOfAtomAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeDescriptor.hpp"

src/Actions/SelectionAction/Molecules/NotAllMoleculesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeDescriptor.hpp"

src/Actions/SelectionAction/Molecules/NotMoleculeByFormulaAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeFormulaDescriptor.hpp"

src/Actions/SelectionAction/Molecules/NotMoleculeByIdAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "molecule.hpp"

src/Actions/SelectionAction/Molecules/NotMoleculeByNameAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "molecule.hpp"

src/Actions/SelectionAction/Molecules/NotMoleculeByOrderAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "molecule.hpp"

src/Actions/SelectionAction/Molecules/NotMoleculeOfAtomAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Descriptors/MoleculeDescriptor.hpp"

src/Actions/SelectionAction/Molecules/PopMoleculesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <boost/bind.hpp>

src/Actions/SelectionAction/Molecules/PushMoleculesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Log.hpp"

src/Actions/SelectionAction/Shapes/AllShapesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Shapes/ShapeRegistry.hpp"

src/Actions/SelectionAction/Shapes/NotAllShapesAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Shapes/ShapeRegistry.hpp"

src/Actions/SelectionAction/Shapes/NotShapeByNameAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Shapes/ShapeRegistry.hpp"

src/Actions/SelectionAction/Shapes/ShapeByNameAction.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Shapes/ShapeRegistry.hpp"