Changeset 9eb71b3 for ThirdParty/LinearAlgebra

Timestamp:

May 5, 2017, 2:08:59 PM (8 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes

Children:

ac9dc8

Parents:

aa91de0

git-author:

Frederik Heber <frederik.heber@…> (05/05/17 12:22:20)

git-committer:

Frederik Heber <frederik.heber@…> (05/05/17 14:08:59)

Message:

Commented out MemDebug include and Memory::ignore.

• MemDebug clashes with various allocation operators that use a specific placement in memory. It is so far not possible to wrap new/delete fully. Hence, we stop this effort which so far has forced us to put ever more includes (with clashes) into MemDebug and thereby bloat compilation time.
• MemDebug does not add that much usefulness which is not also provided by valgrind.

Location:

ThirdParty/LinearAlgebra

Files:

• src/LinearAlgebra/BoxVector.cpp (modified) (1 diff)
• src/LinearAlgebra/Line.cpp (modified) (1 diff)
• src/LinearAlgebra/LinePoint.cpp (modified) (1 diff)
• src/LinearAlgebra/LineSegment.cpp (modified) (1 diff)
• src/LinearAlgebra/LineSegmentSet.cpp (modified) (1 diff)
• src/LinearAlgebra/LinearSystemOfEquations.cpp (modified) (1 diff)
• src/LinearAlgebra/MatrixContent.cpp (modified) (1 diff)
• src/LinearAlgebra/MatrixVector_ops.cpp (modified) (1 diff)
• src/LinearAlgebra/Plane.cpp (modified) (1 diff)
• src/LinearAlgebra/RealSpaceMatrix.cpp (modified) (1 diff)
• src/LinearAlgebra/Space.cpp (modified) (1 diff)
• src/LinearAlgebra/Vector.cpp (modified) (2 diffs)
• src/LinearAlgebra/VectorContent.cpp (modified) (1 diff)
• src/LinearAlgebra/VectorInterface.cpp (modified) (1 diff)
• src/LinearAlgebra/leastsquaremin.cpp (modified) (1 diff)
• src/LinearAlgebra/vector_ops.cpp (modified) (1 diff)
• tests/CodeChecks/testsuite-memdebug.at (modified) (2 diffs)

ThirdParty/LinearAlgebra/src/LinearAlgebra/BoxVector.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <iostream>

ThirdParty/LinearAlgebra/src/LinearAlgebra/Line.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "Line.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/LinePoint.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "LinePoint.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/LineSegment.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "LineSegment.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/LineSegmentSet.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "LineSegmentSet.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/LinearSystemOfEquations.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Assert.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/MatrixContent.cpp

@@ -34 +34 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Assert.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/MatrixVector_ops.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <gsl/gsl_blas.h>

ThirdParty/LinearAlgebra/src/LinearAlgebra/Plane.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <cmath>

ThirdParty/LinearAlgebra/src/LinearAlgebra/RealSpaceMatrix.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Assert.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/Space.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <limits>

ThirdParty/LinearAlgebra/src/LinearAlgebra/Vector.cpp

@@ -32 +32 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Assert.hpp"
@@ -640 +640 @@
 }
 
+#define ignore_mem(x) \
+    /* Memory::ignore( */ x /* ) */
+
+
 // some commonly used vectors
 VectorContent *VCs[4] = {
-    Memory::ignore(new VectorContent((size_t) NDIM)),
-    Memory::ignore(new VectorContent((size_t) NDIM)),
-    Memory::ignore(new VectorContent((size_t) NDIM)),
-    Memory::ignore(new VectorContent((size_t) NDIM))
+        ignore_mem( new VectorContent((size_t) NDIM) ),
+        ignore_mem( new VectorContent((size_t) NDIM) ),
+        ignore_mem( new VectorContent((size_t) NDIM) ),
+        ignore_mem( new VectorContent((size_t) NDIM) )
 };
 

ThirdParty/LinearAlgebra/src/LinearAlgebra/VectorContent.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <gsl/gsl_blas.h>

ThirdParty/LinearAlgebra/src/LinearAlgebra/VectorInterface.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "VectorInterface.hpp"

ThirdParty/LinearAlgebra/src/LinearAlgebra/leastsquaremin.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <iostream>

ThirdParty/LinearAlgebra/src/LinearAlgebra/vector_ops.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include "CodePatterns/Info.hpp"

ThirdParty/LinearAlgebra/tests/CodeChecks/testsuite-memdebug.at

@@ -1 @@
-AT_SETUP([Checking for present MemDebug.hpp include])
+AT_SETUP([Checking for present, deactivated MemDebug.hpp include])
 AT_KEYWORDS([CodeCheck MemDebug])
 ok=""
@@ -22 +22 @@
     if test $found -eq 0
     then
-      AT_CHECK([egrep -q '^#include.*MemDebug.hpp' $file], 0, [ignore], [ignore], [echo "Could not find MemDebug.hpp include in $file."])
+      AT_CHECK([egrep -q '^//#include.*MemDebug.hpp' $file], 0, [ignore], [ignore], [echo "Could not find MemDebug.hpp include in $file."])
     fi
   fi