source: src/unittests/Makefile.am@ e4afb4

Action_Thermostats Add_AtomRandomPerturbation Add_FitFragmentPartialChargesAction Add_RotateAroundBondAction Add_SelectAtomByNameAction Added_ParseSaveFragmentResults AddingActions_SaveParseParticleParameters Adding_Graph_to_ChangeBondActions Adding_MD_integration_tests Adding_ParticleName_to_Atom Adding_StructOpt_integration_tests AtomFragments Automaking_mpqc_open AutomationFragmentation_failures Candidate_v1.5.4 Candidate_v1.6.0 Candidate_v1.6.1 ChangeBugEmailaddress ChangingTestPorts ChemicalSpaceEvaluator CombiningParticlePotentialParsing Combining_Subpackages Debian_Package_split Debian_package_split_molecuildergui_only Disabling_MemDebug Docu_Python_wait EmpiricalPotential_contain_HomologyGraph EmpiricalPotential_contain_HomologyGraph_documentation Enable_parallel_make_install Enhance_userguide Enhanced_StructuralOptimization Enhanced_StructuralOptimization_continued Example_ManyWaysToTranslateAtom Exclude_Hydrogens_annealWithBondGraph FitPartialCharges_GlobalError Fix_BoundInBox_CenterInBox_MoleculeActions Fix_ChargeSampling_PBC Fix_ChronosMutex Fix_FitPartialCharges Fix_FitPotential_needs_atomicnumbers Fix_ForceAnnealing Fix_IndependentFragmentGrids Fix_ParseParticles Fix_ParseParticles_split_forward_backward_Actions Fix_PopActions Fix_QtFragmentList_sorted_selection Fix_Restrictedkeyset_FragmentMolecule Fix_StatusMsg Fix_StepWorldTime_single_argument Fix_Verbose_Codepatterns Fix_fitting_potentials Fixes ForceAnnealing_goodresults ForceAnnealing_oldresults ForceAnnealing_tocheck ForceAnnealing_with_BondGraph ForceAnnealing_with_BondGraph_continued ForceAnnealing_with_BondGraph_continued_betteresults ForceAnnealing_with_BondGraph_contraction-expansion FragmentAction_writes_AtomFragments FragmentMolecule_checks_bonddegrees GeometryObjects Gui_Fixes Gui_displays_atomic_force_velocity ImplicitCharges IndependentFragmentGrids IndependentFragmentGrids_IndividualZeroInstances IndependentFragmentGrids_IntegrationTest IndependentFragmentGrids_Sole_NN_Calculation JobMarket_RobustOnKillsSegFaults JobMarket_StableWorkerPool JobMarket_unresolvable_hostname_fix MoreRobust_FragmentAutomation ODR_violation_mpqc_open PartialCharges_OrthogonalSummation PdbParser_setsAtomName PythonUI_with_named_parameters QtGui_reactivate_TimeChanged_changes Recreated_GuiChecks Rewrite_FitPartialCharges RotateToPrincipalAxisSystem_UndoRedo SaturateAtoms_findBestMatching SaturateAtoms_singleDegree StoppableMakroAction Subpackage_CodePatterns Subpackage_JobMarket Subpackage_LinearAlgebra Subpackage_levmar Subpackage_mpqc_open Subpackage_vmg Switchable_LogView ThirdParty_MPQC_rebuilt_buildsystem TrajectoryDependenant_MaxOrder TremoloParser_IncreasedPrecision TremoloParser_MultipleTimesteps TremoloParser_setsAtomName Ubuntu_1604_changes stable v1.0.6
Last change on this file since e4afb4 was e4afb4, checked in by Frederik Heber <heber@…>, 15 years ago

Huge refactoring: Introduction of Traits to Actions.

This change is really big but the introduction of the Trait concept (at least
in its current light form) is so fundamental that lots of pieces had to be
changed in order to get everything working.

The main point why it was necessary to add these traits in the first place was
to comfortably allow for adding extension of Actions information-wise, i.e.
with stuff that is only important for the QtUI, such as icons, or tooltips, ...
This extra information should not be stored with Action itself, as it has
nothing to do with the workings of the Action. And neither should it get
stored with some blown-out-of-proportions MapOfActions class ...

The gist of the change is as follows:

  • OptionTrait contains the token, description, shortform and type of an option, such as ("position", "position in space, none, typeid(Vector)).
  • ActionTrait is the derived form for actions where additionally MenuPosition and MenuName are stored (and probably more to come for the GUI), also we have a set of OptionTrait instances, one for each option of the Action.
  • Action then contains this ActionTrait, specialized for each Action.
  • the preprocessor macros have been enhanced to gather all this information from the .def files.
  • MapOfActions is gone. Completely. Most of its use was to store this extra information and the ValueStorage part now is just in class ValueStorage.
  • ValueStorage is no more an interface to MapOfActions but as the name says a (type-safe) ValueStorage.

Listing the (remaining) changes in alphabetical order of the class:

  • Action
    • member value ::name dropped, ::getName() uses ActionTraits::getName()
    • new define NODEFAULT which is used in paramdefaults in .def files
    • all derived actions classes such as Process, Calculations, MakroAction,... have been adapated to use the ActionTrait concept as well.
  • ActionHistory
    • extraced RedoAction and UndoAction, shifted implementation into their own object files and they use .def files as well (i.e. streamlined with method used for other actions)
  • MenuDescription
    • contain information on Menus such as name, ...
    • new unit test checks for consistency
  • molecule
    • const member functions: Copy(), Output() and OutputBonds()
  • OptionRegistry
    • new registry class for options only
    • we want the same type throughout the code for each token, e.g. "position"
    • the registry containts checks for consistency
  • OptionTrait
    • default values are specified in paramdefaults, none are given by NODEFAULT
    • introduced default for translate-atoms, point-correlation, pair-correlation
  • Registry pattern
    • new unit test, but only sceleton code so far
  • ...Query, also ...Pipe
    • atoms, molecule and elements are now all const
    • also ValueStorage's signatures all have const therein
  • ValueStorage
    • set/queryCurrentValue from MapOfActions
    • at times VectorValue has been in .def files where Vector was in the signature. This is cleared. Such stuff is only present for e.g. BoxVector being queried as a Vector. But this is a feature and intended.
  • World
    • most of the (un)selection functions now work on const atoms and molecules
    • in one case we need a const_cast to remove this, but this is intentional, as the vector of selected atoms stores non-const pointers and this is ok.

There is only one test which had to be changed slightly because a specific
option token as "position" must now have the same type everywhere, e.g. always
Vector.

  • TESTFIX: Simple_configuration/2: --position -> --domain-position (and associated to BoxVector)
  • Property mode set to 100644
File size: 9.3 KB
Line 
1# PLEASE adhere to the alphabetical ordering in this Makefile!
2# Also indentation by a single tab
3
4INCLUDES = -I$(top_srcdir)/src
5
6AM_LDFLAGS = $(CPPUNIT_LIBS) -ldl
7AM_CXXFLAGS = $(CPPUNIT_CFLAGS)
8
9TESTS = \
10 ActionSequenceTest \
11 ActOnAllUnitTest \
12 AnalysisBondsUnitTests \
13 AnalysisCorrelationToPointUnitTest \
14 AnalysisCorrelationToSurfaceUnitTest \
15 AnalysisPairCorrelationUnitTest \
16 atomsCalculationTest \
17 AtomDescriptorTest \
18 BondGraphUnitTest \
19 BoxUnittest \
20 CacheableTest \
21 CountBondsUnitTest \
22 FormulaUnittest \
23 GSLMatrixSymmetricUnitTest \
24 GSLMatrixUnitTest \
25 GSLVectorUnitTest \
26 InfoUnitTest \
27 LinearSystemOfEquationsUnitTest \
28 LineUnittest \
29 LinkedCellUnitTest \
30 ListOfBondsUnitTest \
31 LogUnitTest \
32 manipulateAtomsTest \
33 MatrixUnittest \
34 MenuDescriptionUnitTest \
35 MoleculeDescriptorTest \
36 ObserverTest \
37 ParserUnitTest \
38 periodentafelTest \
39 PlaneUnittest \
40 Registry \
41 ShapeUnittest \
42 SingletonTest \
43 StackClassUnitTest \
44 TesselationUnitTest \
45 Tesselation_BoundaryTriangleUnitTest \
46 Tesselation_InOutsideUnitTest \
47 VectorUnitTest
48
49
50check_PROGRAMS = $(TESTS)
51noinst_PROGRAMS = $(TESTS) TestRunner
52
53BOOST_LIB = $(BOOST_LDFLAGS) $(BOOST_MPL_LIB) $(BOOST_PROGRAM_OPTIONS_LIB) $(BOOST_FILESYSTEM_LIB) $(BOOST_THREAD_LIB)
54GSLLIBS = \
55 ../LinearAlgebra/libMolecuilderLinearAlgebra-@MOLECUILDER_API_VERSION@.la \
56 ../Exceptions/libMolecuilderExceptions-@MOLECUILDER_API_VERSION@.la \
57 ../Helpers/libMolecuilderHelpers-@MOLECUILDER_API_VERSION@.la \
58 $(BOOST_LIB)
59ALLLIBS = \
60 ../UIElements/libMolecuilderUI-@MOLECUILDER_API_VERSION@.la \
61 ../Actions/libMolecuilderActions-@MOLECUILDER_API_VERSION@.la \
62 ${PARSERLIBS} \
63 ../libMolecuilder-@MOLECUILDER_API_VERSION@.la \
64 ${GSLLIBS}
65
66PARSERLIBS = ../Parser/libMolecuilderParser-@MOLECUILDER_API_VERSION@.la
67UILIBS = ../UIElements/libMolecuilderUI-@MOLECUILDER_API_VERSION@.la
68
69TESTSOURCES = \
70 ActOnAllUnitTest.cpp \
71 ActionSequenceTest.cpp \
72 analysisbondsunittest.cpp \
73 AnalysisCorrelationToPointUnitTest.cpp \
74 AnalysisCorrelationToSurfaceUnitTest.cpp \
75 AnalysisPairCorrelationUnitTest.cpp \
76 AtomDescriptorTest.cpp \
77 atomsCalculationTest.cpp \
78 bondgraphunittest.cpp \
79 BoxUnittest.cpp \
80 CacheableTest.cpp \
81 CountBondsUnitTest.cpp \
82 FormulaUnittest.cpp \
83 gslmatrixsymmetricunittest.cpp \
84 gslmatrixunittest.cpp \
85 gslvectorunittest.cpp \
86 infounittest.cpp \
87 linearsystemofequationsunittest.cpp \
88 LineUnittest.cpp \
89 LinkedCellUnitTest.cpp \
90 listofbondsunittest.cpp \
91 logunittest.cpp \
92 MatrixUnittest.cpp \
93 manipulateAtomsTest.cpp \
94 MenuDescriptionUnitTest.cpp \
95 MoleculeDescriptorTest.cpp \
96 ObserverTest.cpp \
97 ParserUnitTest.cpp \
98 periodentafelTest.cpp \
99 PlaneUnittest.cpp \
100 RegistryUnitTest.cpp \
101 ShapeUnittest.cpp \
102 SingletonTest.cpp \
103 stackclassunittest.cpp \
104 tesselationunittest.cpp \
105 tesselation_boundarytriangleunittest.cpp \
106 tesselation_insideoutsideunittest.cpp \
107 vectorunittest.cpp
108
109TESTHEADERS = \
110 ActOnAllUnitTest.hpp \
111 ActionSequenceTest.hpp \
112 analysisbondsunittest.hpp \
113 AnalysisCorrelationToPointUnitTest.hpp \
114 AnalysisCorrelationToSurfaceUnitTest.hpp \
115 AnalysisPairCorrelationUnitTest.hpp \
116 AtomDescriptorTest.hpp \
117 atomsCalculationTest.hpp \
118 bondgraphunittest.hpp \
119 BoxUnittest.hpp \
120 CacheableTest.hpp \
121 CountBondsUnitTest.hpp \
122 FormulaUnittest.hpp \
123 gslmatrixsymmetricunittest.hpp \
124 gslmatrixunittest.hpp \
125 gslvectorunittest.hpp \
126 infounittest.hpp \
127 linearsystemofequationsunittest.hpp \
128 LineUnittest.hpp \
129 LinkedCellUnitTest.hpp \
130 listofbondsunittest.hpp \
131 logunittest.hpp \
132 manipulateAtomsTest.hpp \
133 MatrixUnittest.hpp \
134 MenuDescriptionUnitTest.hpp \
135 MoleculeDescriptorTest.hpp \
136 ObserverTest.hpp \
137 periodentafelTest.hpp \
138 ParserUnitTest.hpp \
139 PlaneUnittest.hpp \
140 RegistryUnitTest.hpp \
141 SingletonTest.hpp \
142 stackclassunittest.hpp \
143 tesselationunittest.hpp \
144 tesselation_boundarytriangleunittest.hpp \
145 tesselation_insideoutsideunittest.hpp \
146 vectorunittest.hpp
147
148
149ActionSequenceTest_SOURCES = UnitTestMain.cpp ActionSequenceTest.cpp ActionSequenceTest.hpp
150ActionSequenceTest_LDADD = ${UILIBS} ${ALLLIBS}
151
152ActOnAllUnitTest_SOURCES = UnitTestMain.cpp ../test/ActOnAllTest.hpp ActOnAllUnitTest.cpp ActOnAllUnitTest.hpp
153ActOnAllUnitTest_LDADD = ${ALLLIBS}
154
155AnalysisBondsUnitTests_SOURCES = UnitTestMain.cpp analysisbondsunittest.cpp analysisbondsunittest.hpp
156AnalysisBondsUnitTests_LDADD = ${ALLLIBS}
157
158AnalysisCorrelationToPointUnitTest_SOURCES = UnitTestMain.cpp analysis_correlation.hpp AnalysisCorrelationToPointUnitTest.cpp AnalysisCorrelationToPointUnitTest.hpp
159AnalysisCorrelationToPointUnitTest_LDADD = ${ALLLIBS}
160
161AnalysisCorrelationToSurfaceUnitTest_SOURCES = UnitTestMain.cpp analysis_correlation.hpp AnalysisCorrelationToSurfaceUnitTest.cpp AnalysisCorrelationToSurfaceUnitTest.hpp
162AnalysisCorrelationToSurfaceUnitTest_LDADD = ${ALLLIBS}
163
164AnalysisPairCorrelationUnitTest_SOURCES = UnitTestMain.cpp analysis_correlation.hpp AnalysisPairCorrelationUnitTest.cpp AnalysisPairCorrelationUnitTest.hpp
165AnalysisPairCorrelationUnitTest_LDADD = ${ALLLIBS}
166
167atomsCalculationTest_SOURCES = UnitTestMain.cpp atomsCalculationTest.cpp atomsCalculationTest.hpp
168atomsCalculationTest_LDADD = ${ALLLIBS}
169
170AtomDescriptorTest_SOURCES = UnitTestMain.cpp AtomDescriptorTest.cpp AtomDescriptorTest.hpp
171AtomDescriptorTest_LDADD = ${ALLLIBS}
172
173BondGraphUnitTest_SOURCES = UnitTestMain.cpp bondgraphunittest.cpp bondgraphunittest.hpp
174BondGraphUnitTest_LDADD = ${ALLLIBS}
175
176BoxUnittest_SOURCES = UnitTestMain.cpp BoxUnittest.cpp BoxUnittest.hpp
177BoxUnittest_LDADD = ${ALLLIBS}
178
179CacheableTest_SOURCES = UnitTestMain.cpp CacheableTest.cpp CacheableTest.hpp
180CacheableTest_LDADD = ${ALLLIBS}
181
182CountBondsUnitTest_SOURCES = UnitTestMain.cpp CountBondsUnitTest.cpp CountBondsUnitTest.hpp
183CountBondsUnitTest_LDADD = ${ALLLIBS}
184
185FormulaUnittest_SOURCES = UnitTestMain.cpp FormulaUnittest.cpp FormulaUnittest.hpp
186FormulaUnittest_LDADD = ${ALLLIBS}
187
188GSLMatrixSymmetricUnitTest_SOURCES = UnitTestMain.cpp gslmatrixsymmetricunittest.cpp gslmatrixsymmetricunittest.hpp
189GSLMatrixSymmetricUnitTest_LDADD = ${ALLLIBS}
190
191GSLMatrixUnitTest_SOURCES = UnitTestMain.cpp gslmatrixunittest.cpp gslmatrixunittest.hpp
192GSLMatrixUnitTest_LDADD = ${ALLLIBS}
193
194GSLVectorUnitTest_SOURCES = UnitTestMain.cpp gslvectorunittest.cpp gslvectorunittest.hpp
195GSLVectorUnitTest_LDADD = ${ALLLIBS}
196
197InfoUnitTest_SOURCES = UnitTestMain.cpp infounittest.cpp infounittest.hpp
198InfoUnitTest_LDADD = ${ALLLIBS}
199
200LinearSystemOfEquationsUnitTest_SOURCES = UnitTestMain.cpp linearsystemofequationsunittest.cpp linearsystemofequationsunittest.hpp
201LinearSystemOfEquationsUnitTest_LDADD = ${ALLLIBS}
202
203LineUnittest_SOURCES = UnitTestMain.cpp LineUnittest.cpp LineUnittest.hpp
204LineUnittest_LDADD = ${ALLLIBS}
205
206LinkedCellUnitTest_SOURCES = UnitTestMain.cpp LinkedCellUnitTest.cpp LinkedCellUnitTest.hpp
207LinkedCellUnitTest_LDADD = ${ALLLIBS}
208
209ListOfBondsUnitTest_SOURCES = UnitTestMain.cpp listofbondsunittest.cpp listofbondsunittest.hpp
210ListOfBondsUnitTest_LDADD = ${ALLLIBS}
211
212LogUnitTest_SOURCES = UnitTestMain.cpp logunittest.cpp logunittest.hpp
213LogUnitTest_LDADD = ${ALLLIBS}
214
215manipulateAtomsTest_SOURCES = UnitTestMain.cpp manipulateAtomsTest.cpp manipulateAtomsTest.hpp
216manipulateAtomsTest_LDADD = ${UILIBS} ${ALLLIBS}
217
218MatrixUnittest_SOURCES = UnitTestMain.cpp MatrixUnittest.cpp MatrixUnittest.hpp
219MatrixUnittest_LDADD = ${ALLLIBS}
220
221MenuDescriptionUnitTest_SOURCES = UnitTestMain.cpp MenuDescriptionUnitTest.cpp MenuDescriptionUnitTest.hpp
222MenuDescriptionUnitTest_LDADD = ${ALLLIBS}
223
224MoleculeDescriptorTest_SOURCES = UnitTestMain.cpp MoleculeDescriptorTest.cpp MoleculeDescriptorTest.hpp
225MoleculeDescriptorTest_LDADD = ${ALLLIBS}
226
227ObserverTest_SOURCES = UnitTestMain.cpp ObserverTest.cpp ObserverTest.hpp
228ObserverTest_LDADD = ${ALLLIBS}
229
230ParserUnitTest_SOURCES = UnitTestMain.cpp ParserUnitTest.cpp ParserUnitTest.hpp
231ParserUnitTest_LDADD = ${ALLLIBS}
232
233periodentafelTest_SOURCES = UnitTestMain.cpp periodentafelTest.cpp periodentafelTest.hpp
234periodentafelTest_LDADD = ${ALLLIBS}
235
236PlaneUnittest_SOURCES = UnitTestMain.cpp PlaneUnittest.cpp PlaneUnittest.hpp
237PlaneUnittest_LDADD = ${ALLLIBS}
238
239Registry_SOURCES = UnitTestMain.cpp RegistryUnitTest.cpp RegistryUnitTest.hpp
240Registry_LDADD = ${ALLLIBS}
241
242ShapeUnittest_SOURCES = UnitTestMain.cpp ShapeUnittest.cpp ShapeUnittest.hpp
243ShapeUnittest_LDADD = ${ALLLIBS}
244
245SingletonTest_SOURCES = UnitTestMain.cpp SingletonTest.cpp SingletonTest.hpp
246SingletonTest_LDADD = ${ALLLIBS} $(BOOST_LIB) ${BOOST_THREAD_LIB}
247
248StackClassUnitTest_SOURCES = UnitTestMain.cpp stackclassunittest.cpp stackclassunittest.hpp
249StackClassUnitTest_LDADD = ${ALLLIBS}
250
251TesselationUnitTest_SOURCES = UnitTestMain.cpp tesselationunittest.cpp tesselationunittest.hpp
252TesselationUnitTest_LDADD = ${ALLLIBS}
253
254Tesselation_BoundaryTriangleUnitTest_SOURCES = UnitTestMain.cpp tesselation_boundarytriangleunittest.cpp tesselation_boundarytriangleunittest.hpp
255Tesselation_BoundaryTriangleUnitTest_LDADD = ${ALLLIBS}
256
257Tesselation_InOutsideUnitTest_SOURCES = UnitTestMain.cpp tesselation_insideoutsideunittest.cpp tesselation_insideoutsideunittest.hpp
258Tesselation_InOutsideUnitTest_LDADD = ${ALLLIBS}
259
260TestRunner_SOURCES = TestRunnerMain.cpp $(TESTSOURCES) $(TESTHEADERS)
261TestRunner_LDADD = ${UILIBS} ${ALLLIBS}
262
263VectorUnitTest_SOURCES = UnitTestMain.cpp vectorunittest.cpp vectorunittest.hpp
264VectorUnitTest_LDADD = ${ALLLIBS}
265
266#AUTOMAKE_OPTIONS = parallel-tests
Note: See TracBrowser for help on using the repository browser.