source: src/UIElements/Views/Qt4/MoleculeList/SpecificItems/QtMoleculeItem_formula.hpp@ b9680b

Action_Thermostats Add_AtomRandomPerturbation Add_FitFragmentPartialChargesAction Add_RotateAroundBondAction Add_SelectAtomByNameAction Added_ParseSaveFragmentResults AddingActions_SaveParseParticleParameters Adding_Graph_to_ChangeBondActions Adding_MD_integration_tests Adding_ParticleName_to_Atom Adding_StructOpt_integration_tests AtomFragments Automaking_mpqc_open AutomationFragmentation_failures Candidate_v1.5.4 Candidate_v1.6.0 Candidate_v1.6.1 ChangeBugEmailaddress ChangingTestPorts ChemicalSpaceEvaluator CombiningParticlePotentialParsing Combining_Subpackages Debian_Package_split Debian_package_split_molecuildergui_only Disabling_MemDebug Docu_Python_wait EmpiricalPotential_contain_HomologyGraph EmpiricalPotential_contain_HomologyGraph_documentation Enable_parallel_make_install Enhance_userguide Enhanced_StructuralOptimization Enhanced_StructuralOptimization_continued Example_ManyWaysToTranslateAtom Exclude_Hydrogens_annealWithBondGraph FitPartialCharges_GlobalError Fix_BoundInBox_CenterInBox_MoleculeActions Fix_ChargeSampling_PBC Fix_ChronosMutex Fix_FitPartialCharges Fix_FitPotential_needs_atomicnumbers Fix_ForceAnnealing Fix_IndependentFragmentGrids Fix_ParseParticles Fix_ParseParticles_split_forward_backward_Actions Fix_PopActions Fix_QtFragmentList_sorted_selection Fix_Restrictedkeyset_FragmentMolecule Fix_StatusMsg Fix_StepWorldTime_single_argument Fix_Verbose_Codepatterns Fix_fitting_potentials Fixes ForceAnnealing_goodresults ForceAnnealing_oldresults ForceAnnealing_tocheck ForceAnnealing_with_BondGraph ForceAnnealing_with_BondGraph_continued ForceAnnealing_with_BondGraph_continued_betteresults ForceAnnealing_with_BondGraph_contraction-expansion FragmentAction_writes_AtomFragments FragmentMolecule_checks_bonddegrees GeometryObjects Gui_Fixes Gui_displays_atomic_force_velocity ImplicitCharges IndependentFragmentGrids IndependentFragmentGrids_IndividualZeroInstances IndependentFragmentGrids_IntegrationTest IndependentFragmentGrids_Sole_NN_Calculation JobMarket_RobustOnKillsSegFaults JobMarket_StableWorkerPool JobMarket_unresolvable_hostname_fix MoreRobust_FragmentAutomation ODR_violation_mpqc_open PartialCharges_OrthogonalSummation PdbParser_setsAtomName PythonUI_with_named_parameters QtGui_reactivate_TimeChanged_changes Recreated_GuiChecks Rewrite_FitPartialCharges RotateToPrincipalAxisSystem_UndoRedo SaturateAtoms_findBestMatching SaturateAtoms_singleDegree StoppableMakroAction Subpackage_CodePatterns Subpackage_JobMarket Subpackage_LinearAlgebra Subpackage_levmar Subpackage_mpqc_open Subpackage_vmg Switchable_LogView ThirdParty_MPQC_rebuilt_buildsystem TrajectoryDependenant_MaxOrder TremoloParser_IncreasedPrecision TremoloParser_MultipleTimesteps TremoloParser_setsAtomName Ubuntu_1604_changes stable
Last change on this file since b9680b was b9680b, checked in by Frederik Heber <heber@…>, 10 years ago

FIX: Fixing "pure virtual function called" in QtMoleculeItem.

  • as a matter of fact this should not be a problem: Inside QtMoleculeItem's dstor body while signing off from the channels, it is no problem to receive a notification for a channel we have not signed off yet. The vtable has not been touched with respect to QtMoleculeItem. I really do not understand this issue. I have tried to reproduce it with a few mock classes that have the very same inheritance pattern and used locks to force the same case of a virtual function being called while inside the dstor's body but it does not reproduce the error.
  • the same holds for the cstor and again the vtable is created before the code pointer enters the cstor body, hence it should be no problem ...
  • the solution is to signOn..() and signOff..() on the highest level, i.e. on the most derived classes. This causes some code duplication but at least it works.
  • Property mode set to 100644
File size: 2.1 KB
Line 
1/*
2 * QtMoleculeItem_formula.hpp
3 *
4 * Created on: Jan 18, 2015
5 * Author: heber
6 */
7
8#ifndef QTMOLECULEITEM_FORMULA_HPP_
9#define QTMOLECULEITEM_FORMULA_HPP_
10
11// include config.h
12#ifdef HAVE_CONFIG_H
13#include <config.h>
14#endif
15
16#include "UIElements/Views/Qt4/MoleculeList/QtMoleculeItem.hpp"
17
18#include <string>
19
20#include "CodePatterns/ObservedValue.hpp"
21
22#include "Descriptors/MoleculeIdDescriptor.hpp"
23#include "Formula.hpp"
24#include "molecule.hpp"
25#include "World.hpp"
26
27class QtMoleculeItemFactory;
28
29/** This class contains the formula of a molecule and keeps it up to date.
30 *
31 */
32class QtMoleculeItem_formula : public QtMoleculeItem
33{
34 //!> only allow factory to instantiate items
35 friend class QtMoleculeItemFactory;
36
37 QtMoleculeItem_formula(
38 const moleculeId_t _molid,
39 emitDirtyState_t _emitDirtyState) :
40 QtMoleculeItem(_molid, channellist_formula, QtMoleculeItem::NeedsMove, _emitDirtyState),
41 molref(getMolecule()),
42 formula(
43 molref,
44 boost::bind(&QtMoleculeItem_formula::updateFormula, this),
45 "MoleculeItem_formula_"+toString(_molid),
46 updateFormula(),
47 channellist_formula)
48 {
49 signOnToMolecule();
50 // cannot call pure virtual function in QtMoleculeItem's cstor
51 internal_updateState();
52 }
53
54 ~QtMoleculeItem_formula()
55 {
56 signOffFromMolecule();
57 }
58
59 std::string updateFormula() const
60 {
61 const molecule * const mol = getMolecule();
62 if (mol != NULL)
63 return mol->getFormula().toString();
64 else
65 return std::string();
66 }
67
68 /** Performs the update of the molecule's formula.
69 *
70 */
71 void internal_updateState()
72 {
73 setText(QString(formula.get().c_str()));
74 }
75
76 QtMoleculeItem::COLUMNTYPES getType() const
77 { return QtMoleculeItem::FORMULA; }
78
79 //!> notification channels of molecule specific to this molecule item, required for update
80 static const QtMoleculeItem::channellist_t channellist_formula;
81
82 //!> temporary value for molecule
83 const molecule * const molref;
84
85 //!> contains visibility state
86 ObservedValue<std::string> formula;
87};
88
89
90
91#endif /* QTMOLECULEITEM_FORMULA_HPP_ */
Note: See TracBrowser for help on using the repository browser.